If you notice some outdated information please let us know!
PASS
The final review score is indicated as a percentage. The percentage is calculated as Achieved Points due to MAX Possible Points. For each element the answer can be either Yes/No or a percentage. For a detailed breakdown of the individual weights of each question, please consult this document.
Very simply, the audit looks for the following declarations from the developer's site. With these declarations, it is reasonable to trust the smart contracts.
This report is for informational purposes only and does not constitute investment advice of any kind, nor does it constitute an offer to provide investment advisory or other services. Nothing in this report shall be considered a solicitation or offer to buy or sell any security, token, future, option or other financial instrument or to offer or provide any investment advice or service to any person in any jurisdiction. Nothing contained in this report constitutes investment advice or offers any opinion with respect to the suitability of any security, and the views expressed in this report should not be taken as advice to buy, sell or hold any security. The information in this report should not be relied upon for the purpose of investing. In preparing the information contained in this report, we have not taken into account the investment needs, objectives and financial circumstances of any particular investor. This information has no regard to the specific investment objectives, financial situation and particular needs of any specific recipient of this information and investments discussed may not be suitable for all investors.
Any views expressed in this report by us were prepared based upon the information available to us at the time such views were written. The views expressed within this report are limited to DeFiSafety and the author and do not reflect those of any additional or third party and are strictly based upon DeFiSafety, its authors, interpretations and evaluation of relevant data. Changed or additional information could cause such views to change. All information is subject to possible correction. Information may quickly become unreliable for various reasons, including changes in market conditions or economic circumstances.
This completed report is copyright (c) DeFiSafety 2023. Permission is given to copy in whole, retaining this copyright label.
This section looks at the code deployed on the Mainnet that gets reviewed and its corresponding software repository. The document explaining these questions is here.
1. Are the executing code addresses readily available? (%)
They are available at websites https://docs.pooltogether.com/resources/networks/ethereum, https://docs.pooltogether.com/resources/networks/celo#celo, https://docs.pooltogether.com/resources/networks/xdai, https://docs.pooltogether.com/resources/networks/matic, https://docs.pooltogether.com/resources/networks/binance, as indicated in the Appendix.
2. Is the code actively being used? (%)
Activity is 177 transactions a day on Polygon contract 0xEE06AbE9e2Af61cabcb13170e01266Af2DEFa946, as indicated in the Appendix.
3. Is there a public software repository? (Y/N)
GitHub: https://github.com/pooltogether
Is there a public software repository with the code at a minimum, but also normally test and scripts. Even if the repository was created just to hold the files and has just 1 transaction, it gets a "Yes". For teams with private repositories, this answer is "No"
4. Is there a development history visible? (%)
With 878 commits and 30 branches, this is clearly a well-maintained repository.
This metric checks if the software repository demonstrates a strong steady history. This is normally demonstrated by commits, branches and releases in a software repository. A healthy history demonstrates a history of more than a month (at a minimum).
5. Is the team public (not anonymous)? (Y/N)
Location: Protocol members are clearly listed in their medium articles.
For a "Yes" in this question, the real names of some team members must be public on the website or other documentation (LinkedIn, etc). If the team is anonymous, then this question is a "No".
This section looks at the software documentation. The document explaining these questions is here.
7. Are the basic software functions documented? (Y/N)
8. Does the software function documentation fully (100%) cover the deployed contracts? (%)
All contracts and functions are clearly explained with well-ordered and robust documentation.
9. Are there sufficiently detailed comments for all functions within the deployed contract code (%)
The Comments to Code (CtC) ratio is the primary metric for this score.
10. Is it possible to trace from software documentation to the implementation in code (%)
There is nonexplicit traceability between the code and the documentation at a requirement level for all code.
11. Full test suite (Covers all the deployed code) (%)
This score is guided by the Test to Code ratio (TtC). Generally a good test to code ratio is over 100%. However the reviewers best judgement is the final deciding factor.
12. Code coverage (Covers all the deployed lines of code, or explains misses) (%)
13. Scripts and instructions to run the tests? (Y/N)
Scrips/Instructions location: https://github.com/pooltogether/pooltogether-pool-contracts
14. Report of the results (%)
Coveralls test report can be found at https://coveralls.io/jobs/87058204.
15. Formal Verification test done (%)
There is no evidence of formal verification.
16. Stress Testing environment (%)
There is evidence of stress testing on the Rinkeby Testnet for many protocol versions.
This section looks at the 3rd party software audits done. It is explained in this document.
17. Did 3rd Party audits take place? (%)
PoolTogether has undergone three external audits. Open Zeppelin has audited the protocol twice, and ditCraft has once - though no proof could be found for this third audit.
18. Is the bug bounty acceptable high? (%)
There is a bug bounty program offering up to $25,000.
This section covers the documentation of special access controls for a DeFi protocol. The admin access controls are the contracts that allow updating contracts or coefficients in the protocol. Since these contracts can allow the protocol admins to "change the rules", complete disclosure of capabilities is vital for user's transparency. It is explained in this document.
19. Can a user clearly and quickly find the status of the access controls (%)
Controls are clearly detailed in the docs here: https://docs.pooltogether.com/governance/controls
20. Is the information clear and complete (%)
All Contracts are clearly labelled as non upgreadeable, AKA immutable.
21. Is the information in non-technical terms that pertain to the investments (%)
All contracts are clearly labelled as non-upgradeable.
22. Is there Pause Control documentation including records of tests (%)
All contracts are clearly labelled as non-upgradeable.
1abstract contract PrizePool is PrizePoolInterface, OwnableUpgradeable, ReentrancyGuardUpgradeable, TokenControllerInterface, IERC721ReceiverUpgradeable {
2 using SafeMathUpgradeable for uint256;
3 using SafeCastUpgradeable for uint256;
4 using SafeERC20Upgradeable for IERC20Upgradeable;
5 using SafeERC20Upgradeable for IERC721Upgradeable;
6 using MappedSinglyLinkedList for MappedSinglyLinkedList.Mapping;
7 using ERC165CheckerUpgradeable for address;
8
9 /// @dev Emitted when an instance is initialized
10 event Initialized(
11 address reserveRegistry,
12 uint256 maxExitFeeMantissa
13 );
14
15 /// @dev Event emitted when controlled token is added
16 event ControlledTokenAdded(
17 ControlledTokenInterface indexed token
18 );
19
20 /// @dev Emitted when reserve is captured.
21 event ReserveFeeCaptured(
22 uint256 amount
23 );
24
25 event AwardCaptured(
26 uint256 amount
27 );
28
29 /// @dev Event emitted when assets are deposited
30 event Deposited(
31 address indexed operator,
32 address indexed to,
33 address indexed token,
34 uint256 amount,
35 address referrer
36 );
37
38 /// @dev Event emitted when interest is awarded to a winner
39 event Awarded(
40 address indexed winner,
41 address indexed token,
42 uint256 amount
43 );
44
45 /// @dev Event emitted when external ERC20s are awarded to a winner
46 event AwardedExternalERC20(
47 address indexed winner,
48 address indexed token,
49 uint256 amount
50 );
51
52 /// @dev Event emitted when external ERC20s are transferred out
53 event TransferredExternalERC20(
54 address indexed to,
55 address indexed token,
56 uint256 amount
57 );
58
59 /// @dev Event emitted when external ERC721s are awarded to a winner
60 event AwardedExternalERC721(
61 address indexed winner,
62 address indexed token,
63 uint256[] tokenIds
64 );
65
66 /// @dev Event emitted when assets are withdrawn instantly
67 event InstantWithdrawal(
68 address indexed operator,
69 address indexed from,
70 address indexed token,
71 uint256 amount,
72 uint256 redeemed,
73 uint256 exitFee
74 );
75
76 event ReserveWithdrawal(
77 address indexed to,
78 uint256 amount
79 );
80
81 /// @dev Event emitted when the Liquidity Cap is set
82 event LiquidityCapSet(
83 uint256 liquidityCap
84 );
85
86 /// @dev Event emitted when the Credit plan is set
87 event CreditPlanSet(
88 address token,
89 uint128 creditLimitMantissa,
90 uint128 creditRateMantissa
91 );
92
93 /// @dev Event emitted when the Prize Strategy is set
94 event PrizeStrategySet(
95 address indexed prizeStrategy
96 );
97
98 /// @dev Emitted when credit is minted
99 event CreditMinted(
100 address indexed user,
101 address indexed token,
102 uint256 amount
103 );
104
105 /// @dev Emitted when credit is burned
106 event CreditBurned(
107 address indexed user,
108 address indexed token,
109 uint256 amount
110 );
111
112 /// @dev Emitted when there was an error thrown awarding an External ERC721
113 event ErrorAwardingExternalERC721(bytes error);
114
115
116 struct CreditPlan {
117 uint128 creditLimitMantissa;
118 uint128 creditRateMantissa;
119 }
120
121 struct CreditBalance {
122 uint192 balance;
123 uint32 timestamp;
124 bool initialized;
125 }
126
127 /// @notice Semver Version
128 string constant public VERSION = "3.4.5";
129
130 /// @dev Reserve to which reserve fees are sent
131 RegistryInterface public reserveRegistry;
132
133 /// @dev An array of all the controlled tokens
134 ControlledTokenInterface[] internal _tokens;
135
136 /// @dev The Prize Strategy that this Prize Pool is bound to.
137 TokenListenerInterface public prizeStrategy;
138
139 /// @dev The maximum possible exit fee fraction as a fixed point 18 number.
140 /// For example, if the maxExitFeeMantissa is "0.1 ether", then the maximum exit fee for a withdrawal of 100 Dai will be 10 Dai
141 uint256 public maxExitFeeMantissa;
142
143 /// @dev The total funds that have been allocated to the reserve
144 uint256 public reserveTotalSupply;
145
146 /// @dev The total amount of funds that the prize pool can hold.
147 uint256 public liquidityCap;
148
149 /// @dev the The awardable balance
150 uint256 internal _currentAwardBalance;
151
152 /// @dev Stores the credit plan for each token.
153 mapping(address => CreditPlan) internal _tokenCreditPlans;
154
155 /// @dev Stores each users balance of credit per token.
156 mapping(address => mapping(address => CreditBalance)) internal _tokenCreditBalances;
157
158 /// @notice Initializes the Prize Pool
159 // @param _controlledTokens Array of ControlledTokens that are controlled by this Prize Pool.
160 // @param _maxExitFeeMantissa The maximum exit fee size
161 function initialize (
162 RegistryInterface _reserveRegistry,
163 ControlledTokenInterface[] memory _controlledTokens,
164 uint256 _maxExitFeeMantissa
165 )
166 public
167 initializer
168 {
169 require(address(_reserveRegistry) != address(0), "PrizePool/reserveRegistry-not-zero");
170 uint256 controlledTokensLength = _controlledTokens.length;
171 _tokens = new ControlledTokenInterface[](controlledTokensLength);
172
173 for (uint256 i = 0; i < controlledTokensLength; i++) {
174 ControlledTokenInterface controlledToken = _controlledTokens[i];
175 _addControlledToken(controlledToken, i);
176 }
177 __Ownable_init();
178 __ReentrancyGuard_init();
179 _setLiquidityCap(uint256(-1));
180
181 reserveRegistry = _reserveRegistry;
182 maxExitFeeMantissa = _maxExitFeeMantissa;
183
184 emit Initialized(
185 address(_reserveRegistry),
186 maxExitFeeMantissa
187 );
188 }
Comments to Code: 869 / 2281 = 38 %
Tests to Code: 3905 / 2281 = 171 %