If you notice some outdated information please let us know!
PASS
The final review score is indicated as a percentage. The percentage is calculated as Achieved Points due to MAX Possible Points. For each element the answer can be either Yes/No or a percentage. For a detailed breakdown of the individual weights of each question, please consult this document.
Very simply, the audit looks for the following declarations from the developer's site. With these declarations, it is reasonable to trust the smart contracts.
This report is for informational purposes only and does not constitute investment advice of any kind, nor does it constitute an offer to provide investment advisory or other services. Nothing in this report shall be considered a solicitation or offer to buy or sell any security, token, future, option or other financial instrument or to offer or provide any investment advice or service to any person in any jurisdiction. Nothing contained in this report constitutes investment advice or offers any opinion with respect to the suitability of any security, and the views expressed in this report should not be taken as advice to buy, sell or hold any security. The information in this report should not be relied upon for the purpose of investing. In preparing the information contained in this report, we have not taken into account the investment needs, objectives and financial circumstances of any particular investor. This information has no regard to the specific investment objectives, financial situation and particular needs of any specific recipient of this information and investments discussed may not be suitable for all investors.
Any views expressed in this report by us were prepared based upon the information available to us at the time such views were written. The views expressed within this report are limited to DeFiSafety and the author and do not reflect those of any additional or third party and are strictly based upon DeFiSafety, its authors, interpretations and evaluation of relevant data. Changed or additional information could cause such views to change. All information is subject to possible correction. Information may quickly become unreliable for various reasons, including changes in market conditions or economic circumstances.
This completed report is copyright (c) DeFiSafety 2023. Permission is given to copy in whole, retaining this copyright label.
This section looks at the code deployed on the Mainnet that gets reviewed and its corresponding software repository. The document explaining these questions is here.
1. Are the executing code addresses readily available? (%)
They are available at website https://docs.lido.fi/deployed-contracts as indicated in the Appendix.
2. Is the code actively being used? (%)
Activity is 500 transactions a day on contract deposit_contract.sol, as indicated in the Appendix.
3. Is there a public software repository? (Y/N)
GitHub: https://github.com/lidofinance
Is there a public software repository with the code at a minimum, but also normally test and scripts. Even if the repository was created just to hold the files and has just 1 transaction, it gets a "Yes". For teams with private repositories, this answer is "No"
4. Is there a development history visible? (%)
With 1108 commits and 40 branches, this is a very healthy software repository.
This metric checks if the software repository demonstrates a strong steady history. This is normally demonstrated by commits, branches and releases in a software repository. A healthy history demonstrates a history of more than a month (at a minimum).
5. Is the team public (not anonymous)? (Y/N)
No public dev identities have been found.
For a "Yes" in this question, the real names of some team members must be public on the website or other documentation (LinkedIn, etc). If the team is anonymous, then this question is a "No".
This section looks at the software documentation. The document explaining these questions is here.
7. Are the basic software functions documented? (Y/N)
8. Does the software function documentation fully (100%) cover the deployed contracts? (%)
https://docs.lido.fi/contracts/lido only covers the major functions.
9. Are there sufficiently detailed comments for all functions within the deployed contract code (%)
The Comments to Code (CtC) ratio is the primary metric for this score.
10. Is it possible to trace from software documentation to the implementation in code (%)
There is clear explicit traceability between software documentation and its implementation in code.
11. Full test suite (Covers all the deployed code) (%)
This score is guided by the Test to Code ratio (TtC). Generally a good test to code ratio is over 100%. However the reviewers best judgement is the final deciding factor.
12. Code coverage (Covers all the deployed lines of code, or explains misses) (%)
Their Quantstamp audit covers most of the Lido.fi code.
13. Scripts and instructions to run the tests? (Y/N)
Instructions to run rests can be found at the bottom of https://github.com/lidofinance/lido-dao
14. Report of the results (%)
Guidance: 100% Detailed test report as described below 70% GitHub Code coverage report visible 0% No test report evident
15. Formal Verification test done (%)
No formal verification of Lido.fi is evident.
16. Stress Testing environment (%)
Multiple test-net smart contract addresses available at https://docs.lido.fi/deployed-contracts
This section looks at the 3rd party software audits done. It is explained in this document.
17. Did 3rd Party audits take place? (%)
18. Is the bug bounty acceptable high? (%)
Bug Bounty program found at https://immunefi.com/bounty/lido/.
This section covers the documentation of special access controls for a DeFi protocol. The admin access controls are the contracts that allow updating contracts or coefficients in the protocol. Since these contracts can allow the protocol admins to "change the rules", complete disclosure of capabilities is vital for user's transparency. It is explained in this document.
19. Can a user clearly and quickly find the status of the access controls (%)
Lido.fi uses Aragon as a DAO framework that the base themselves off of. In their docs, they provide operator frameworks at https://docs.lido.fi/guides/node-operator-manual
20. Is the information clear and complete (%)
21. Is the information in non-technical terms that pertain to the investments (%)
Guidance: 100% All the contracts are immutable 90% Description relates to investments safety and updates in clear, complete non-software l language 30% Description all in software specific language 0% No admin control information could not be found
22. Is there Pause Control documentation including records of tests (%)
Pause Control documentation explained at https://docs.lido.fi/guides/protocol-levers#pausing, but no evidence of regular tests.
1
2// SPDX-License-Identifier: CC0-1.0
3
4pragma solidity 0.6.11;
5
6// This interface is designed to be compatible with the Vyper version.
7/// @notice This is the Ethereum 2.0 deposit contract interface.
8/// For more information see the Phase 0 specification under https://github.com/ethereum/eth2.0-specs
9interface IDepositContract {
10 /// @notice A processed deposit event.
11 event DepositEvent(
12 bytes pubkey,
13 bytes withdrawal_credentials,
14 bytes amount,
15 bytes signature,
16 bytes index
17 );
18
19 /// @notice Submit a Phase 0 DepositData object.
20 /// @param pubkey A BLS12-381 public key.
21 /// @param withdrawal_credentials Commitment to a public key for withdrawals.
22 /// @param signature A BLS12-381 signature.
23 /// @param deposit_data_root The SHA-256 hash of the SSZ-encoded DepositData object.
24 /// Used as a protection against malformed input.
25 function deposit(
26 bytes calldata pubkey,
27 bytes calldata withdrawal_credentials,
28 bytes calldata signature,
29 bytes32 deposit_data_root
30 ) external payable;
31
32 /// @notice Query the current deposit root hash.
33 /// @return The deposit root hash.
34 function get_deposit_root() external view returns (bytes32);
35
36 // @notice Query the current deposit count.
37 // @return The deposit count encoded as a little endian 64-bit number.
38 function get_deposit_count() external view returns (bytes memory);
39}
40
41// Based on official specification in https://eips.ethereum.org/EIPS/eip-165
42interface ERC165 {
43 /// @notice Query if a contract implements an interface
44 /// @param interfaceId The interface identifier, as specified in ERC-165
45 /// @dev Interface identification is specified in ERC-165. This function
46 /// uses less than 30,000 gas.
47 /// @return `true` if the contract implements `interfaceId` and
48 /// `interfaceId` is not 0xffffffff, `false` otherwise
49 function supportsInterface(bytes4 interfaceId) external pure returns (bool);
50}
51
52// This is a rewrite of the Vyper Eth2.0 deposit contract in Solidity.
53// It tries to stay as close as possible to the original source code.
54/// @notice This is the Ethereum 2.0 deposit contract interface.
55/// For more information see the Phase 0 specification under https://github.com/ethereum/eth2.0-specs
56contract DepositContract is IDepositContract, ERC165 {
57 uint constant DEPOSIT_CONTRACT_TREE_DEPTH = 32;
58 // NOTE: this also ensures `deposit_count` will fit into 64-bits
59 uint constant MAX_DEPOSIT_COUNT = 2**DEPOSIT_CONTRACT_TREE_DEPTH - 1;
60
Comments to Code: 1372 / 2163 = 63 %
Tests to Code: 5359 / 2163 = 248 %