If you notice some outdated information please let us know!
-10%(Penalty)
FAIL
The final review score is indicated as a percentage. The percentage is calculated as Achieved Points due to MAX Possible Points. For each element the answer can be either Yes/No or a percentage. For a detailed breakdown of the individual weights of each question, please consult this document.
Very simply, the audit looks for the following declarations from the developer's site. With these declarations, it is reasonable to trust the smart contracts.
This report is for informational purposes only and does not constitute investment advice of any kind, nor does it constitute an offer to provide investment advisory or other services. Nothing in this report shall be considered a solicitation or offer to buy or sell any security, token, future, option or other financial instrument or to offer or provide any investment advice or service to any person in any jurisdiction. Nothing contained in this report constitutes investment advice or offers any opinion with respect to the suitability of any security, and the views expressed in this report should not be taken as advice to buy, sell or hold any security. The information in this report should not be relied upon for the purpose of investing. In preparing the information contained in this report, we have not taken into account the investment needs, objectives and financial circumstances of any particular investor. This information has no regard to the specific investment objectives, financial situation and particular needs of any specific recipient of this information and investments discussed may not be suitable for all investors.
Any views expressed in this report by us were prepared based upon the information available to us at the time such views were written. The views expressed within this report are limited to DeFiSafety and the author and do not reflect those of any additional or third party and are strictly based upon DeFiSafety, its authors, interpretations and evaluation of relevant data. Changed or additional information could cause such views to change. All information is subject to possible correction. Information may quickly become unreliable for various reasons, including changes in market conditions or economic circumstances.
This completed report is copyright (c) DeFiSafety 2023. Permission is given to copy in whole, retaining this copyright label.
This section looks at the code deployed on the relevant chain that gets reviewed and its corresponding software repository. The document explaining these questions is here.
1. Are the smart contract addresses easy to find? (%)
KyberSwap Elastic's core smart contracts can be found in the protocol's documentation under Contract Deployment. A screenshot of the addresses can be found in the appendix. KyberSwap Classic's smart contracts can be found here
2. How active is the primary contract? (%)
KyberSwap's Polygon Router is active more than 10 times a day; the polygonscan's information can be found here. A screenshot of the analytics can be found in the appendix.
3. Does the protocol have a public software repository? (Y/N)
KyberSwap's GitHub: https://github.com/KyberNetwork.
4. Is there a development history visible? (%)
The KyberSwap repository has 5340 commits, 66 branches.
5. Is the team public (not anonymous)?
This section looks at the software documentation. The document explaining these questions is here.
7. Is the protocol's software architecture documented? (Y/N)
This protocol's software architecture is thoroughly explained through written explanations and graphs. The Technical Explanation documentation offers an example of how meticulous the KyberSwap team is on the platform's technicalities.
8. Does the software documentation fully cover the deployed contracts' source code? (%)
KyberSwap offers complete coverage of its smart contract functions here.
9. Is it possible to trace the documented software to its implementation in the protocol's source code? (%)
There is implicit traceability between software documentation and implemented code as cross-referencing can be done to trace back the smart contract functions to the source code. An easy fix would be to allow a hyperlink to the functions so that users can directly access the source code through the function's documentation.
10. Has the protocol tested their deployed code? (%)
Our research gives out a 300% test to code ratio on the Smart-contracts-master file. This is calculated by comparing the lines of code deployed to the lines of test code.
11. How covered is the protocol's code? (%)
There are no coverage documentation, but there is clearly a complete set of tests.
12. Does the protocol provide scripts and instructions to run their tests? (Y/N)
Scripts/Instructions location:[https://github.com/KyberNetwork/smart-contracts#testing-with-buidler] (https://github.com/KyberNetwork/smart-contracts#testing-with-buidler)
13. Is there a detailed report of the protocol's test results?(%)
There are no explicit detailed reports on test results for KyberSwap.
14. Has the protocol undergone Formal Verification? (Y/N)
This protocol has not undergone formal verification.
15. Were the smart contracts deployed to a testnet? (Y/N)
KyberSwap provides Ropsten testnet contract addresses here.
This section looks at the 3rd party software audits done. It is explained in this document.
16. Is the protocol sufficiently audited? (%)
Kyber's current version (V3) has been audited by Chainsecurity on Janurary 9th, 2019. All major and critical issues were fixed and most light issues were fixed or acknowledged. Launch date assumption: January 30th, 2019
17. Is the bounty value acceptably high (%)
No bug bounty could be found for KyberSwap.
This section covers the documentation of special access controls for a DeFi protocol. The admin access controls are the contracts that allow updating contracts or coefficients in the protocol. Since these contracts can allow the protocol admins to "change the rules", complete disclosure of capabilities is vital for user's transparency. It is explained in this document.
18. Is the protocol's admin control information easy to find?
There is a governance forum for KyberSwap to push proposals forward, but this does not constitute admin control information. An easy fix would be to create a section in the documentation covering administrative roles and capabilities in regards to smart contract upgradeability.
19. Are relevant contracts clearly labelled as upgradeable or immutable? (%)
Immutable parameters are listed here. However, there are no explicit mentions of upgradeability for other smart contracts.
20. Is the type of smart contract ownership clearly indicated? (%)
Contract ownerships are not explicitly documented but ownership can be found in the code; for instance, KyberNetwork.sol has OnlyAdmin() ownership, like here. For that matter, the protocol earns 50%.
21. Are the protocol's smart contract change capabilities described? (%)
Smart contract change capabilities are not identified.
22. Is the protocol's admin control information easy to understand? (%)
There are no admin control information available.
23. Is there sufficient Pause Control documentation? (%)
There is no pause control documentation available for KyberSwap.
24. Is there sufficient Timelock documentation? (%)
There is no timelock documentation available for KyberSwap.
25. Is the Timelock of an adequate length? (Y/N)
There is no timelock documentation available for KyberSwap.
This section goes over the documentation that a protocol may or may not supply about their Oracle usage. Oracles are a fundamental part of DeFi as they are responsible for relaying tons of price data information to thousands of protocols using blockchain technology. Not only are they important for price feeds, but they are also an essential component of transaction verification and security. These questions are explained in this document.
26. Is the protocol's Oracle sufficiently documented? (%)
There is no oracle documentation provided for KyberSwap. As an AMM, this is likely because it does not use one. However, further clarification is needed given the importance of this issue.
27. Is front running mitigated by this protocol? (Y/N)
KyberSwap describes front running as Sniping attack and describes its mitigation techniques through slippage limitation parameters here.
28. Can flashloan attacks be applied to the protocol, and if so, are those flashloan attack risks mitigated? (Y/N)
Flashloan attack mitigation techniques are not documented.
1pragma solidity 0.6.6;
2
3import "./utils/WithdrawableNoModifiers.sol";
4import "./utils/Utils5.sol";
5import "./utils/zeppelin/ReentrancyGuard.sol";
6import "./utils/zeppelin/SafeERC20.sol";
7import "./IKyberNetwork.sol";
8import "./IKyberReserve.sol";
9import "./IKyberFeeHandler.sol";
10import "./IKyberDao.sol";
11import "./IKyberMatchingEngine.sol";
12import "./IKyberStorage.sol";
13import "./IGasHelper.sol";
14
15
16/**
17 * @title kyberNetwork main contract
18 * Interacts with contracts:
19 * kyberDao: to retrieve fee data
20 * kyberFeeHandler: accumulates and distributes trade fees
21 * kyberMatchingEngine: parse user hint and run reserve matching algorithm
22 * kyberStorage: store / access reserves, token listings and contract addresses
23 * kyberReserve(s): query rate and trade
24 */
25contract KyberNetwork is WithdrawableNoModifiers, Utils5, IKyberNetwork, ReentrancyGuard {
26 using SafeERC20 for IERC20;
27
28 struct NetworkFeeData {
29 uint64 expiryTimestamp;
30 uint16 feeBps;
31 }
32
33 /// @notice Stores work data for reserves (either for token -> eth, or eth -> token)
34 /// @dev Variables are in-place, ie. reserve with addresses[i] has id of ids[i], offers rate of rates[i], etc.
35 /// @param addresses List of reserve addresses selected for the trade
36 /// @param ids List of reserve ids, to be used for KyberTrade event
37 /// @param rates List of rates that were offered by the reserves
38 /// @param isFeeAccountedFlags List of reserves requiring users to pay network fee
39 /// @param isEntitledRebateFlags List of reserves eligible for rebates
40 /// @param splitsBps List of proportions of trade amount allocated to the reserves.
41 /// If there is only 1 reserve, then it should have a value of 10000 bps
42 /// @param srcAmounts Source amount per reserve.
43 /// @param decimals Token decimals. Src decimals when for src -> eth, dest decimals when eth -> dest
44 struct ReservesData {
45 IKyberReserve[] addresses;
46 bytes32[] ids;
47 uint256[] rates;
48 bool[] isFeeAccountedFlags;
49 bool[] isEntitledRebateFlags;
50 uint256[] splitsBps;
51 uint256[] srcAmounts;
52 uint256 decimals;
53 }
54
55 /// @notice Main trade data structure, is initialised and used for the entire trade flow
56 /// @param input Initialised when initTradeInput is called. Stores basic trade info
57 /// @param tokenToEth Stores information about reserves that were selected for src -> eth side of trade
58 /// @param ethToToken Stores information about reserves that were selected for eth -> dest side of trade
59 /// @param tradeWei Trade amount in ether wei, before deducting fees.
60 /// @param networkFeeWei Network fee in ether wei. For t2t trades, it can go up to 200% of networkFeeBps
61 /// @param platformFeeWei Platform fee in ether wei
62 /// @param networkFeeBps Network fee bps determined by kyberDao, or default value
63 /// @param numEntitledRebateReserves No. of reserves that are eligible for rebates
64 /// @param feeAccountedBps Proportion of this trade that fee is accounted to, in BPS. Up to 2 * BPS
65 struct TradeData {
66 TradeInput input;
67 ReservesData tokenToEth;
68 ReservesData ethToToken;
69 uint256 tradeWei;
70 uint256 networkFeeWei;
71 uint256 platformFeeWei;
72 uint256 networkFeeBps;
73 uint256 numEntitledRebateReserves;
74 uint256 feeAccountedBps; // what part of this trade is fee paying. for token -> token - up to 200%
75 }
76
77 struct TradeInput {
78 address payable trader;
79 IERC20 src;
80 uint256 srcAmount;
81 IERC20 dest;
82 address payable destAddress;
83 uint256 maxDestAmount;
84 uint256 minConversionRate;
85 address platformWallet;
86 uint256 platformFeeBps;
87 }
88
89 uint256 internal constant PERM_HINT_GET_RATE = 1 << 255; // for backwards compatibility
90 uint256 internal constant DEFAULT_NETWORK_FEE_BPS = 25; // till we read value from kyberDao
91 uint256 internal constant MAX_APPROVED_PROXIES = 2; // limit number of proxies that can trade here
92
93 IKyberFeeHandler internal kyberFeeHandler;
94 IKyberDao internal kyberDao;
95 IKyberMatchingEngine internal kyberMatchingEngine;
96 IKyberStorage internal kyberStorage;
97 IGasHelper internal gasHelper;
98
99 NetworkFeeData internal networkFeeData; // data is feeBps and expiry timestamp
100 uint256 internal maxGasPriceValue = 50 * 1000 * 1000 * 1000; // 50 gwei
101 bool internal isEnabled = false; // is network enabled
102
103 mapping(address => bool) internal kyberProxyContracts;
104
105 event EtherReceival(address indexed sender, uint256 amount);
106 event KyberFeeHandlerUpdated(IKyberFeeHandler newKyberFeeHandler);
107 event KyberMatchingEngineUpdated(IKyberMatchingEngine newKyberMatchingEngine);
108 event GasHelperUpdated(IGasHelper newGasHelper);
109 event KyberDaoUpdated(IKyberDao newKyberDao);
110 event KyberNetworkParamsSet(uint256 maxGasPrice, uint256 negligibleRateDiffBps);
111 event KyberNetworkSetEnable(bool isEnabled);
112 event KyberProxyAdded(address kyberProxy);
113 event KyberProxyRemoved(address kyberProxy);
114
115 event ListedReservesForToken(
116 IERC20 indexed token,
117 address[] reserves,
118 bool add
119 );
120
121 constructor(address _admin, IKyberStorage _kyberStorage)
122 public
123 WithdrawableNoModifiers(_admin)
124 {
125 updateNetworkFee(now, DEFAULT_NETWORK_FEE_BPS);
126 kyberStorage = _kyberStorage;
127 }
128
129 receive() external payable {
130 emit EtherReceival(msg.sender, msg.value);
131 }
132
133 /// @notice Backward compatible function
134 /// @notice Use token address ETH_TOKEN_ADDRESS for ether
135 /// @dev Trade from src to dest token and sends dest token to destAddress
136 /// @param trader Address of the taker side of this trade
137 /// @param src Source token
138 /// @param srcAmount Amount of src tokens in twei
139 /// @param dest Destination token
140 /// @param destAddress Address to send tokens to
141 /// @param maxDestAmount A limit on the amount of dest tokens in twei
142 /// @param minConversionRate The minimal conversion rate. If actual rate is lower, trade reverts
143 /// @param walletId Platform wallet address for receiving fees
144 /// @param hint Advanced instructions for running the trade
145 /// @return destAmount Amount of actual dest tokens in twei
146 function tradeWithHint(
147 address payable trader,
148 ERC20 src,
149 uint256 srcAmount,
150 ERC20 dest,
151 address payable destAddress,
152 uint256 maxDestAmount,
153 uint256 minConversionRate,
154 address payable walletId,
Tests to Code: 47900 / 15934 = 301 %