If you notice some outdated information please let us know!
FAIL
The final review score is indicated as a percentage. The percentage is calculated as Achieved Points due to MAX Possible Points. For each element the answer can be either Yes/No or a percentage. For a detailed breakdown of the individual weights of each question, please consult this document.
Very simply, the audit looks for the following declarations from the developer's site. With these declarations, it is reasonable to trust the smart contracts.
This report is for informational purposes only and does not constitute investment advice of any kind, nor does it constitute an offer to provide investment advisory or other services. Nothing in this report shall be considered a solicitation or offer to buy or sell any security, token, future, option or other financial instrument or to offer or provide any investment advice or service to any person in any jurisdiction. Nothing contained in this report constitutes investment advice or offers any opinion with respect to the suitability of any security, and the views expressed in this report should not be taken as advice to buy, sell or hold any security. The information in this report should not be relied upon for the purpose of investing. In preparing the information contained in this report, we have not taken into account the investment needs, objectives and financial circumstances of any particular investor. This information has no regard to the specific investment objectives, financial situation and particular needs of any specific recipient of this information and investments discussed may not be suitable for all investors.
Any views expressed in this report by us were prepared based upon the information available to us at the time such views were written. The views expressed within this report are limited to DeFiSafety and the author and do not reflect those of any additional or third party and are strictly based upon DeFiSafety, its authors, interpretations and evaluation of relevant data. Changed or additional information could cause such views to change. All information is subject to possible correction. Information may quickly become unreliable for various reasons, including changes in market conditions or economic circumstances.
This completed report is copyright (c) DeFiSafety 2023. Permission is given to copy in whole, retaining this copyright label.
This section looks at the code deployed on the relevant chain that gets reviewed and its corresponding software repository. The document explaining these questions is here.
1. Are the smart contract addresses easy to find? (%)
Clearly listed and labelled contract addresses can be found at this location, as indicated in the Appendix.
2. How active is the primary contract? (%)
Contract "Treasury" is moderately active being used approximately twice a day, as indicated in the Appendix.
3. Does the protocol have a public software repository? (Y/N)
Atlas stores their data in Github.
4. Is there a development history visible? (%)
Atlas has little to no development history available at 1 commit and 1 branch in their main and only repository.
5. Is the team public (not anonymous)?
USV is publicly advertised as venture led by Tai Lopez. With one public name identified to the project, the project earns 50%.
This section looks at the software documentation. The document explaining these questions is here.
6. Is there a whitepaper? (Y/N)
Location: https://docs.atlasusv.com/introduction/
7. Is the protocol's software architecture documented? (Y/N)
No software architecture could be found for Atlas USV.
8. Does the software documentation fully cover the deployed contracts' source code? (%)
No software architecture could be found for Atlas USV.
9. Is it possible to trace the documented software to its implementation in the protocol's source code? (%)
No software architecture could be found for Atlas USV.
10. Has the protocol tested their deployed code? (%)
Code examples are in the Appendix at the end of this report.. As per the SLOC, there is 33% testing to code (TtC). This score is guided by the Test to Code ratio (TtC). Generally a good test to code ratio is over 100%. However, the reviewer's best judgement is the final deciding factor.
11. How covered is the protocol's code? (%)
No code coverage report found, however there is an evident set of tests.
12. Does the protocol provide scripts and instructions to run their tests? (Y/N)
Scripts/Instructions location: https://github.com/AtlasUSV/atlas-contracts/tree/master/scripts
13. Is there a detailed report of the protocol's test results?(%)
No test report found.
14. Has the protocol undergone Formal Verification? (Y/N)
Atlas USV has not undergone formal verification.
15. Were the smart contracts deployed to a testnet? (Y/N)
There is evidence of testnet deployments on Ethereum testnets such as Rinkeby. Example provided here.
This section looks at the 3rd party software audits done. It is explained in this document.
16. Is the protocol sufficiently audited? (%)
Atlas has been audited twice, post-deployment. The reports are public, however the most recent Certik audit indicates several issues (2 major) which have gone unresolved. Launch date assumption: November 2021 TechRate: post deployment, low severity issues CertiK: post deployment, 2 major severities, changes unimplemented
17. Is the bounty value acceptably high (%)
Atlas has no indication of a bug bounty program being offered.
This section covers the documentation of special access controls for a DeFi protocol. The admin access controls are the contracts that allow updating contracts or coefficients in the protocol. Since these contracts can allow the protocol admins to "change the rules", complete disclosure of capabilities is vital for user's transparency. It is explained in this document.
18. Is the protocol's admin control information easy to find?
Atlas does not provide any admin control information.
19. Are relevant contracts clearly labelled as upgradeable or immutable? (%)
Atlas does not provide any admin control information.
20. Is the type of smart contract ownership clearly indicated? (%)
Atlas does not provide any admin control information.
21. Are the protocol's smart contract change capabilities described? (%)
Atlas does not provide any admin control information.
22. Is the protocol's admin control information easy to understand? (%)
Atlas does not provide any admin control information.
23. Is there sufficient Pause Control documentation? (%)
No pause control information found.
24. Is there sufficient Timelock documentation? (%)
No timelock information found.
25. Is the Timelock of an adequate length? (Y/N)
No timelock information found.
This section goes over the documentation that a protocol may or may not supply about their Oracle usage. Oracles are a fundamental part of DeFi as they are responsible for relaying tons of price data information to thousands of protocols using blockchain technology. Not only are they important for price feeds, but they are also an essential component of transaction verification and security. These questions are explained in this document.
26. Is the protocol's Oracle sufficiently documented? (%)
No oracle is named / no oracle information is documented.
27. Is front running mitigated by this protocol? (Y/N)
Atlas does not mention front running and does not document any countermeasure against it.
28. Can flashloan attacks be applied to the protocol, and if so, are those flashloan attack risks mitigated? (Y/N)
Atlas does not mention flash loan attacks and does not document any countermeasure against it.
1/**
2 *Submitted for verification at Etherscan.io on 2021-12-01
3*/
4
5// SPDX-License-Identifier: AGPL-3.0-or-later
6pragma solidity 0.7.5;
7
8library SafeMath {
9 /**
10 * @dev Returns the addition of two unsigned integers, reverting on
11 * overflow.
12 *
13 * Counterpart to Solidity's `+` operator.
14 *
15 * Requirements:
16 *
17 * - Addition cannot overflow.
18 */
19 function add(uint256 a, uint256 b) internal pure returns (uint256) {
20 uint256 c = a + b;
21 require(c >= a, "SafeMath: addition overflow");
22
23 return c;
24 }
Tests to Code: 1384 / 4192 = 33 %