If you notice some outdated information please let us know!
Process Quality Review (0.8)
RenVM
PASS
Scoring Appendix
The final review score is indicated as a percentage. The percentage is calculated as Achieved Points due to MAX Possible Points. For each element the answer can be either Yes/No or a percentage. For a detailed breakdown of the individual weights of each question, please consult this document.
Very simply, the audit looks for the following declarations from the developer's site. With these declarations, it is reasonable to trust the smart contracts.
- Here is my smart contract on the blockchain
- You can see it matches a software repository used to develop the code
- Here is the documentation that explains what my smart contract does
- Here are the tests I ran to verify my smart contract
- Here are the audit(s) performed to review my code by third party experts
This report is for informational purposes only and does not constitute investment advice of any kind, nor does it constitute an offer to provide investment advisory or other services. Nothing in this report shall be considered a solicitation or offer to buy or sell any security, token, future, option or other financial instrument or to offer or provide any investment advice or service to any person in any jurisdiction. Nothing contained in this report constitutes investment advice or offers any opinion with respect to the suitability of any security, and the views expressed in this report should not be taken as advice to buy, sell or hold any security. The information in this report should not be relied upon for the purpose of investing. In preparing the information contained in this report, we have not taken into account the investment needs, objectives and financial circumstances of any particular investor. This information has no regard to the specific investment objectives, financial situation and particular needs of any specific recipient of this information and investments discussed may not be suitable for all investors.
Any views expressed in this report by us were prepared based upon the information available to us at the time such views were written. The views expressed within this report are limited to DeFiSafety and the author and do not reflect those of any additional or third party and are strictly based upon DeFiSafety, its authors, interpretations and evaluation of relevant data. Changed or additional information could cause such views to change. All information is subject to possible correction. Information may quickly become unreliable for various reasons, including changes in market conditions or economic circumstances.
This completed report is copyright (c) DeFiSafety 2023. Permission is given to copy in whole, retaining this copyright label.
Smart Contracts & Team
100%
This section looks at the code deployed on the relevant chain that gets reviewed and its corresponding software repository. The document explaining these questions is here.
1. Are the smart contract addresses easy to find? (%)
RenVM's smart contract addresses could easily be found at https://renproject.github.io/ren-client-docs/contracts/deployments, as indicated in the Appendix.
2. How active is the primary contract? (%)
Contract Darknode Registry has been used 41 times per day, as indicated in the Appendix.
3. Does the protocol have a public software repository? (Y/N)
Location: https://github.com/renproject.
4. Is there a development history visible? (%)
RenVM has an active and frequently updated development history, at 1,386 commits and 30 branches.
5. Is the team public (not anonymous)?
RenVM's team is public. Where we found the team is documented in our team appendix at the end of this report.
Documentation
94%
This section looks at the software documentation. The document explaining these questions is here.
6. Is there a whitepaper? (Y/N)
Location: https://github.com/renproject/ren/wiki#introduction
7. Is the protocol's software architecture documented? (Y/N)
RenVM's software architecture is documented in full through written explanations on how the smart contracts interact.
8. Does the software documentation fully cover the deployed contracts' source code? (%)
There is full and complete coverage of RenVM's deployed contracts by software function documentation.
9. Is it possible to trace the documented software to its implementation in the protocol's source code? (%)
There is implicit traceability between RenVM's software documentation and deployed code.
Testing
96%
10. Has the protocol tested their deployed code? (%)
Code examples are in the Appendix at the end of this report.. As per the SLOC, there is 239% testing to code (TtC). This score is guided by the Test to Code ratio (TtC). Generally a good test to code ratio is over 100%. However, the reviewer's best judgement is the final deciding factor.
11. How covered is the protocol's code? (%)
Code coverage is 93% as per the https://coveralls.io/github/renproject/darknode-sol?branch=master data.
12. Does the protocol provide scripts and instructions to run their tests? (Y/N)
13. Is there a detailed report of the protocol's test results?(%)
The coveralls report provides some of the data required.
14. Has the protocol undergone Formal Verification? (Y/N)
RenVM has undergone formal verification and the report is available.
15. Were the smart contracts deployed to a testnet? (Y/N)
Security
100%
This section looks at the 3rd party software audits done. It is explained in this document.
16. Is the protocol sufficiently audited? (%)
RenVM has been sufficiently audited with four audits documented performed before and after deployments.
17. Is the bounty value acceptably high (%)
RenVM offers an active and fruitful bug bounty of $1M.
Admin Controls
31%
This section covers the documentation of special access controls for a DeFi protocol. The admin access controls are the contracts that allow updating contracts or coefficients in the protocol. Since these contracts can allow the protocol admins to "change the rules", complete disclosure of capabilities is vital for user's transparency. It is explained in this document.
18. Is the protocol's admin control information easy to find?
RenVM has some admin control documentation here, but this is not nearly enough to warrant any points.
19. Are relevant contracts clearly labelled as upgradeable or immutable? (%)
Aside from some previous upgrades to contracts documented here, there is no explicit mention of upgradeability by every smart contract.
20. Is the type of smart contract ownership clearly indicated? (%)
Ownership is Multisig, which is clearly indicated in this location.
21. Are the protocol's smart contract change capabilities described? (%)
Smart contract change capabilities are identified here for some smart contracts.
22. Is the protocol's admin control information easy to understand? (%)
RenVM's does not have enough tangible Admin Control information to warrant a score for this section.
23. Is there sufficient Pause Control documentation? (%)
Pause control not documented or explained.
24. Is there sufficient Timelock documentation? (%)
This protocol has a 7-day timelock documentation which can be found at this location. The documentation covers which contracts it applies to however does not justify the reason for the time period nor provide further explanation.
25. Is the Timelock of an adequate length? (Y/N)
The timelock is of a 7-day relevant length, as specified in this location.
Oracles
100%
This section goes over the documentation that a protocol may or may not supply about their Oracle usage. Oracles are a fundamental part of DeFi as they are responsible for relaying tons of price data information to thousands of protocols using blockchain technology. Not only are they important for price feeds, but they are also an essential component of transaction verification and security. These questions are explained in this document.
26. Is the protocol's Oracle sufficiently documented? (%)
RenVM's oracle source is Chainlink documented at this location. Chainlink is used for getting price feeds for RenVM's cross-chain assets, and their respective feeds and refresh rates can be found by looking up a corresponding asset.
27. Is front running mitigated by this protocol? (Y/N)
RenVM's core functionalities of bridging, which function purely on minting or burning, do not allow any sensitivity to MEV or front running.
28. Can flashloan attacks be applied to the protocol, and if so, are those flashloan attack risks mitigated? (Y/N)
RenVM's architecture inherently guarantees finality within the the bridging process. There is no room for any external manipulation.
Appendices
1/**
2 *Submitted for verification at Etherscan.io on 2020-03-25
3*/
4
5/**
6
7Deployed by Ren Project, https://renproject.io
8
9Commit hash: 9068f80
10Repository: https://github.com/renproject/darknode-sol
11Issues: https://github.com/renproject/darknode-sol/issues
12
13Licenses
14@openzeppelin/contracts: (MIT) https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/LICENSE
15darknode-sol: (GNU GPL V3) https://github.com/renproject/darknode-sol/blob/master/LICENSE
16
17*/
18
19pragma solidity 0.5.16;
20
21
22library SafeMath {
23
24 function add(uint256 a, uint256 b) internal pure returns (uint256) {
25 uint256 c = a + b;
26 require(c >= a, "SafeMath: addition overflow");
27
28 return c;
29 }
30
31
32 function sub(uint256 a, uint256 b) internal pure returns (uint256) {
33 return sub(a, b, "SafeMath: subtraction overflow");
34 }
35
36
37 function sub(uint256 a, uint256 b, string memory errorMessage) internal pure returns (uint256) {
38 require(b <= a, errorMessage);
39 uint256 c = a - b;
40
41 return c;
42 }
43
44
45 function mul(uint256 a, uint256 b) internal pure returns (uint256) {
46
47
48
49 if (a == 0) {
50 return 0;
51 }
52
53 uint256 c = a * b;
54 require(c / a == b, "SafeMath: multiplication overflow");
55
56 return c;
57 }
58
59
60 function div(uint256 a, uint256 b) internal pure returns (uint256) {
61 return div(a, b, "SafeMath: division by zero");
62 }
63
64
65 function div(uint256 a, uint256 b, string memory errorMessage) internal pure returns (uint256) {
66
67 require(b > 0, errorMessage);
68 uint256 c = a / b;
69
70
71 return c;
72 }
73
74
75 function mod(uint256 a, uint256 b) internal pure returns (uint256) {
76 return mod(a, b, "SafeMath: modulo by zero");
77 }
78
79
80 function mod(uint256 a, uint256 b, string memory errorMessage) internal pure returns (uint256) {
81 require(b != 0, errorMessage);
82 return a % b;
83 }
84}
85
86contract Proxy {
87
88 function () payable external {
89 _fallback();
90 }
91
92
93 function _implementation() internal view returns (address);
94
95
96 function _delegate(address implementation) internal {
97 assembly {
98
99
100
JavaScript Tests
Tests to Code: 4791 / 2003 = 239 %