logo
bg_imgbg_imgbg_imgbg_img
exclamation mark iconReport an issue

If you notice some outdated information please let us know!

close icon
Name
Email
Your message
arrow-left

UniFi

43%

Process Quality Review (0.8)

UniFi

Final score:43%
Date:01 Apr 2022
Audit Process:version 0.8
Author:Nick
PQR Score:43%

FAIL

Scoring Appendix

The final review score is indicated as a percentage. The percentage is calculated as Achieved Points due to MAX Possible Points. For each element the answer can be either Yes/No or a percentage. For a detailed breakdown of the individual weights of each question, please consult this document.

The blockchain used by this protocol
Avalanche
BnB Smart Chain
Ethereum
Polygon
Harmony
BitTorrent Chain
Ontology
Tron
IoTeX
Icon
#QuestionAnswer
76%
1.70%
2.100%
3.Yes
4.0%
5.100
89%
6.Yes
7.Yes
8.80%
9.80%
10%
10.0%
11.0%
12.No
13.0%
14.No
15.Yes
78%
16.90%
17.0%
0%
18.0%
19.0%
20.0%
21.0%
22.0%
23.0%
24.0%
25.0%
25%
26.50
27.No
28.No
Total:43%

Very simply, the audit looks for the following declarations from the developer's site. With these declarations, it is reasonable to trust the smart contracts.

  • Here is my smart contract on the blockchain
  • You can see it matches a software repository used to develop the code
  • Here is the documentation that explains what my smart contract does
  • Here are the tests I ran to verify my smart contract
  • Here are the audit(s) performed to review my code by third party experts

This report is for informational purposes only and does not constitute investment advice of any kind, nor does it constitute an offer to provide investment advisory or other services. Nothing in this report shall be considered a solicitation or offer to buy or sell any security, token, future, option or other financial instrument or to offer or provide any investment advice or service to any person in any jurisdiction. Nothing contained in this report constitutes investment advice or offers any opinion with respect to the suitability of any security, and the views expressed in this report should not be taken as advice to buy, sell or hold any security. The information in this report should not be relied upon for the purpose of investing. In preparing the information contained in this report, we have not taken into account the investment needs, objectives and financial circumstances of any particular investor. This information has no regard to the specific investment objectives, financial situation and particular needs of any specific recipient of this information and investments discussed may not be suitable for all investors.

Any views expressed in this report by us were prepared based upon the information available to us at the time such views were written. The views expressed within this report are limited to DeFiSafety and the author and do not reflect those of any additional or third party and are strictly based upon DeFiSafety, its authors, interpretations and evaluation of relevant data. Changed or additional information could cause such views to change. All information is subject to possible correction. Information may quickly become unreliable for various reasons, including changes in market conditions or economic circumstances.

This completed report is copyright (c) DeFiSafety 2023. Permission is given to copy in whole, retaining this copyright label.

Smart Contracts & Team

76%

This section looks at the code deployed on the relevant chain that gets reviewed and its corresponding software repository. The document explaining these questions is here.

1. Are the smart contract addresses easy to find? (%)

Answer: 70%

They can be found at https://github.com/unifiprotocol/utrade-contracts/blob/main/BTT/Contracts.md, as indicated in the Appendix. This took some researching to locate.

Percentage Score Guidance:
100%
Clearly labelled and on website, documents or repository, quick to find
70%
Clearly labelled and on website, docs or repo but takes a bit of looking
40%
Addresses in mainnet.json, in discord or sub graph, etc
20%
Address found but labeling not clear or easy to find
0%
Executing addresses could not be found

2. How active is the primary contract? (%)

Answer: 100%

Contract UniFiFactory is used over 20 times a day, as indicated in the Appendix. Despite the considerable utility and power of the BTT block explorer, we were unable to get day-specific contract interactions. We reached this figure by dividing total contract interactions (2357) by number of days active (105).

Percentage Score Guidance:
100%
More than 10 transactions a day
70%
More than 10 transactions a week
40%
More than 10 transactions a month
10%
Less than 10 transactions a month
0%
No activity

3. Does the protocol have a public software repository? (Y/N)

Answer: Yes

UniFi uses GitHub.

Score Guidance:
Yes
There is a public software repository with the code at a minimum, but also normally test and scripts. Even if the repository was created just to hold the files and has just 1 transaction.
No
For teams with private repositories.

4. Is there a development history visible? (%)

Answer: 0%

At 19 commits, there is not a strong development history. We are pleased to report that this is in line with his excellency Justin Sun's preferences and indeed requirements.

Percentage Score Guidance:
100%
Any one of 100+ commits, 10+branches
70%
Any one of 70+ commits, 7+branches
50%
Any one of 50+ commits, 5+branches
30%
Any one of 30+ commits, 3+branches
0%
Less than 2 branches or less than 30 commits

5. Is the team public (not anonymous)?

Answer: 100

Multiple team members could be identified as contributing to UniFi.

Score Guidance:
100%
At least two names can be easily found in the protocol's website, documentation or medium. These are then confirmed by the personal websites of the individuals / their linkedin / twitter.
50%
At least one public name can be found to be working on the protocol.
0%
No public team members could be found.

Documentation

89%

This section looks at the software documentation. The document explaining these questions is here.

6. Is there a whitepaper? (Y/N)

Answer: Yes

Location: https://docs.unifiprotocol.com/

7. Is the protocol's software architecture documented? (Y/N)

Answer: Yes

This protocol's software architecture is documented in large parts. A diagram explaining how the contracts function would further user comprehension of this protocol.

Score Guidance:
Yes
The documents identify software architecture and contract interaction through any of the following: diagrams, arrows, specific reference to software functions or a written explanation on how smart contracts interact.
No
Protocols receive a "no" if none of these are included.

8. Does the software documentation fully cover the deployed contracts' source code? (%)

Answer: 80%

There is significant coverage of deployed contracts by software function documentation. Some contracts nevertheless remain uncovered by software function documentation.

Percentage Score Guidance:
100%
All contracts and functions documented
80%
Only the major functions documented
79 - 1%
Estimate of the level of software documentation
0%
No software documentation

9. Is it possible to trace the documented software to its implementation in the protocol's source code? (%)

Answer: 80%

There is perfect traceability between software documentation and implemented code, though this is not for all contracts.

Percentage Score Guidance:
100%
Clear explicit traceability between code and documentation at a requirement level for all code
60%
Clear association between code and documents via non explicit traceability
40%
Documentation lists all the functions and describes their functions
0%
No connection between documentation and code

Testing

10%

10. Has the protocol tested their deployed code? (%)

Answer: 0%

No testing was documented in UniFi's repository. This makes His Excellency most content, given his previous commitment to ensuring that POLONIEX is widely known as YOLONIEX.

Percentage Score Guidance:
100%
TtC > 120% Both unit and system test visible
80%
TtC > 80% Both unit and system test visible
40%
TtC < 80% Some tests visible
0%
No tests obvious

11. How covered is the protocol's code? (%)

Answer: 0%

There is no proof of testing in UniFi's , let alone testing for code coverage. His Excellency once more is deeply satisfied by this development.

Percentage Score Guidance:
100%
Documented full coverage
99 - 51%
Value of test coverage from documented results
50%
No indication of code coverage but clearly there is a complete set of tests
30%
Some tests evident but not complete
0%
No test for coverage seen

12. Does the protocol provide scripts and instructions to run their tests? (Y/N)

Answer: No

No scripts were provided by UniFi for testing.

Score Guidance:
Yes
Scripts and/or instructions to run tests are available in the testing suite
No
Scripts and/or instructions to run tests are not available in the testing suite

13. Is there a detailed report of the protocol's test results?(%)

Answer: 0%

There is no test report provided by UniFi about the tests run on contract code. Mr Sun His Excellency of Grenada is over the moon at this prospect.

Percentage Score Guidance:
100%
Detailed test report as described below
70%
GitHub code coverage report visible
0%
No test report evident

14. Has the protocol undergone Formal Verification? (Y/N)

Answer: No

Unifi has surprisingly not undergone formal verification.

Score Guidance:
Yes
Formal Verification was performed and the report is readily available
No
Formal Verification was not performed and/or the report is not readily available.

15. Were the smart contracts deployed to a testnet? (Y/N)

Answer: Yes

UniFi has documented been deployed to Ropsten testnet.

Score Guidance:
Yes
Protocol has proved their tesnet usage by providing the addresses
No
Protocol has not proved their testnet usage by providing the addresses

Security

78%

This section looks at the 3rd party software audits done. It is explained in this document.

16. Is the protocol sufficiently audited? (%)

Answer: 90%

UniFi was audited once by SlowMist. This audit was pre-deployment.

Percentage Score Guidance:
100%
Multiple Audits performed before deployment and the audit findings are public and implemented or not required
90%
Single audit performed before deployment and audit findings are public and implemented or not required
70%
Audit(s) performed after deployment and no changes required. The Audit report is public.
65%
Code is forked from an already audited protocol and a changelog is provided explaining why forked code was used and what changes were made. This changelog must justify why the changes made do not affect the audit.
50%
Audit(s) performed after deployment and changes are needed but not implemented.
30%
Audit(s) performed are low-quality and do not indicate proper due diligence.
20%
No audit performed
0%
Audit Performed after deployment, existence is public, report is not public OR smart contract address' not found.
Deduct 25% if the audited code is not available for comparison.

17. Is the bounty value acceptably high (%)

Answer: 0%

UniFi does not offer a bug bounty at this time.

Percentage Score Guidance:
100%
Bounty is 10% TVL or at least $1M AND active program (see below)
90%
Bounty is 5% TVL or at least 500k AND active program
80%
Bounty is 5% TVL or at least 500k
70%
Bounty is 100k or over AND active program
60%
Bounty is 100k or over
50%
Bounty is 50k or over AND active program
40%
Bounty is 50k or over
20%
Bug bounty program bounty is less than 50k
0%
No bug bounty program offered / the bug bounty program is dead
An active program means that a third party (such as Immunefi) is actively driving hackers to the site. An inactive program would be static mentions on the docs.

Admin Controls

0%

This section covers the documentation of special access controls for a DeFi protocol. The admin access controls are the contracts that allow updating contracts or coefficients in the protocol. Since these contracts can allow the protocol admins to "change the rules", complete disclosure of capabilities is vital for user's transparency. It is explained in this document.

18. Is the protocol's admin control information easy to find?

Answer: 0%

Admin control information was not documented. There is no information relating to controls in UniFi's documentation or repo. Given these custom contracts, this should be explained.

Percentage Score Guidance:
100%
Admin Controls are clearly labelled and on website, docs or repo, quick to find
70%
Admin Controls are clearly labelled and on website, docs or repo but takes a bit of looking
40%
Admin Control docs are in multiple places and not well labelled
20%
Admin Control docs are in multiple places and not labelled
0%
Admin Control information could not be found

19. Are relevant contracts clearly labelled as upgradeable or immutable? (%)

Answer: 0%

UniFi's relevant contracts are not identified as immutable or upgradeable.

Percentage Score Guidance:
100%
Both the contract documentation and the smart contract code state that the code is not upgradeable or immutable.
80%
All Contracts are clearly labelled as upgradeable (or not)
50%
Code is immutable but not mentioned anywhere in the documentation
0%
Admin control information could not be found

20. Is the type of smart contract ownership clearly indicated? (%)

Answer: 0%

Ownership is not clearly indicated in any UniFi documentation.

Percentage Score Guidance:
100%
The type of ownership is clearly indicated in their documentation. (OnlyOwner / MultiSig / etc)
50%
The type of ownership is indicated, but only in the code. (OnlyOwner / MultiSig / etc)
0%
Admin Control information could not be found

21. Are the protocol's smart contract change capabilities described? (%)

Answer: 0%

UniFi's smart contract change capabilities are not identified for any contracts.

Percentage Score Guidance:
100%
The documentation covers the capabilities for change for all smart contracts
50%
The documentation covers the capabilities for change in some, but not all contracts
0%
The documentation does not cover the capabilities for change in any contract

22. Is the protocol's admin control information easy to understand? (%)

Answer: 0%

The information is completely absent.

Percentage Score Guidance:
100%
All the contracts are immutable
90%
Description relates to investments safety in clear non-software language
30%
Description all in software-specific language
0%
No admin control information could be found

23. Is there sufficient Pause Control documentation? (%)

Answer: 0%

UniFi's pause control is not documented or explained.

Percentage Score Guidance:
100%
If immutable and no changes possible
100%
If admin control is fully via governance
80%
Robust transaction signing process (7 or more elements)
70%
Adequate transaction signing process (5 or more elements)
60%
Weak transaction signing process (3 or more elements)
0%
No transaction signing process evident
Evidence of audits of signers following the process add 20%

24. Is there sufficient Timelock documentation? (%)

Answer: 0%

UniFi has no timelock documentation.

Percentage Score Guidance:
100%
Documentation identifies and explains why the protocol does not need a Timelock OR Timelock documentation identifies its duration, which contracts it applies to and justifies this time period.
60%
A Timelock is identified and its duration is specified
30%
A Timelock is identified
0%
No Timelock information was documented

25. Is the Timelock of an adequate length? (Y/N)

Answer: 0%

UniFi has no timelock documentation, making identification of length impossible.

Percentage Score Guidance:
100%
Timelock is between 48 hours to 1 week OR justification as to why no Timelock is needed / is outside this length.
50%
Timelock is less than 48 hours or greater than 1 week.
0%
No Timelock information was documented OR no timelock length was identified.

Oracles

25%

This section goes over the documentation that a protocol may or may not supply about their Oracle usage. Oracles are a fundamental part of DeFi as they are responsible for relaying tons of price data information to thousands of protocols using blockchain technology. Not only are they important for price feeds, but they are also an essential component of transaction verification and security. These questions are explained in this document.

26. Is the protocol's Oracle sufficiently documented? (%)

Answer: 50

UniFi's oracle source is documented at this location. The contracts dependent are not identified. There is some relevant software function documentation.

Score Guidance:
100%
If it uses one, the Oracle is specified. The contracts dependent on the oracle are identified. Basic software functions are identified (if the protocol provides its own price feed data). Timeframe of price feeds are identified. OR The reason as to why the protocol does not use an Oracle is identified and explained.
75%
The Oracle documentation identifies both source and timeframe, but does not provide additional context regarding smart contracts.
50%
Only the Oracle source is identified.
0%
No oracle is named / no oracle information is documented.

27. Is front running mitigated by this protocol? (Y/N)

Answer: No

UniFi documents no front running mitigation techniques.

Score Guidance:
Yes
The protocol cannot be front run and there is an explanation as to why OR documented front running countermeasures are implemented.
No
The Oracle documentation identifies both source and timeframe, but does not provide additional context regarding smart contracts.

28. Can flashloan attacks be applied to the protocol, and if so, are those flashloan attack risks mitigated? (Y/N)

Answer: No

UniFi documents no flashloan countermeasures.

Score Guidance:
Yes
The protocol's documentation includes information on how they mitigate the possibilities and extents of flash loan attacks.
No
The protocol's documentation does not include any information regarding the mitigation of flash loan attacks.

Appendices

1pragma solidity =0.5.16;
2
3import './UnifiPair.sol';
4
5contract UnifiFactory is IUnifiFactory {
6    bytes32 public constant INIT_CODE_PAIR_HASH = keccak256(abi.encodePacked(type(UnifiPair).creationCode));
7
8    address public feeTo;
9    address public feeToSetter;
10    
11    address public feeController;
12    address public feeControllerSetter;
13    address public wbnb;
14    address public router;    
15    mapping(address => mapping(address => address)) public getPair;
16    address[] public allPairs;
17
18    event PairCreated(address indexed token0, address indexed token1, address pair, uint);
19
20    constructor(address _ufc ,address _wbnb ) public {
21        feeToSetter = msg.sender;
22        feeControllerSetter       =  msg.sender;
23        feeController = _ufc;//change this in future
24        wbnb = _wbnb;
25        
26    }
27
28    function allPairsLength() external view returns (uint) {
29        return allPairs.length;
30    }
31
32    function createPair(address tokenA, address tokenB) external returns (address pair) {
33        require(tokenA != tokenB, 'Unifi: IDENTICAL_ADDRESSES');
34        (address token0, address token1) = tokenA < tokenB ? (tokenA, tokenB) : (tokenB, tokenA);
35        require(token0 != address(0), 'Unifi: ZERO_ADDRESS');
36        require(getPair[token0][token1] == address(0), 'Unifi: PAIR_EXISTS'); // single check is sufficient
37        bytes memory bytecode = type(UnifiPair).creationCode;
38        bytes32 salt = keccak256(abi.encodePacked(token0, token1));
39        assembly {
40            pair := create2(0, add(bytecode, 32), mload(bytecode), salt)
41        }
42  
43        IUnifiPair(pair).initialize(token0, token1,wbnb);
44        getPair[token0][token1] = pair;
45        getPair[token1][token0] = pair; // populate mapping in the reverse direction
46        allPairs.push(pair);
47        emit PairCreated(token0, token1, pair, allPairs.length);
48    }
49
50    function setFeeTo(address _feeTo) external {
51        require(msg.sender == feeToSetter, 'Unifi: FORBIDDEN');
52        feeTo = _feeTo;
53    }
54
55    function setFeeToSetter(address _feeToSetter) external {
56        require(msg.sender == feeToSetter, 'Unifi: FORBIDDEN');
57        feeToSetter = _feeToSetter;
58    }
59    
60    function setFeeControler(address _feeController) external {
61        require(msg.sender == feeControllerSetter, 'Unifi: FORBIDDEN');
62        feeController = _feeController;
63    }
64
65    function setFeeControlerSetter(address _feeControllerSetter) external {
66        require(msg.sender == feeControllerSetter, 'Unifi: FORBIDDEN');
67        feeControllerSetter = _feeControllerSetter;
68    }
69    
70    function setRouter(address _routerAddress) external {
71        require(msg.sender == feeControllerSetter, 'Unifi: FORBIDDEN');
72        router = _routerAddress;
73    }
74
75}
N/A